Milan Zamazal has posted comments on this change. Change subject: v2v: Lazy loading of external VMs info ......................................................................
Patch Set 2: (1 comment) Just one PEP8 issue, otherwise fine for me now. https://gerrit.ovirt.org/#/c/57418/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 167: else: Line 168: # The reason we use vm.ID() instead of vm.isActive() here is Line 169: # because ID is already available after _list_domains(), Line 170: # but vm.isActive() requires another API call to the Line 171: # hypervisor. Beware of the final whitespace, PEP8 tools are going to complain. Line 172: vms.append({'vmName': vm.name(), Line 173: 'status': 'Up' if vm.ID() > -1 else 'Down'}) Line 174: Line 175: return {'status': doneCode, 'vmList': vms} -- To view, visit https://gerrit.ovirt.org/57418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dc6fc4573b2c0b1c03ed87025452e14af2fc566 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
