Milan Zamazal has posted comments on this change. Change subject: utils: Fix bug in tobool() ......................................................................
Patch Set 1: Code-Review-1 Let's be a bit careful. We've had issues with string<->unicode conversions involving non-ASCII characters in the past. For this reason, it'd be better to add isinstance(s,basestring) check before using `lower' rather than the `str' conversion. (And I dislike the original implementation of this function as well as its use too so I don't mind any harsher action to it.) -- To view, visit https://gerrit.ovirt.org/57511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1740f82f5fa5eb50c319b46ce428bbb9f8c0c15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
