Dan Kenigsberg has posted comments on this change.
Change subject: Log if timed out during fileSD.scanDomains().
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
even though commit message should not be so cryptic.
....................................................
Commit Message
Line 5: CommitDate: 2012-10-11 19:36:34 +0200
Line 6:
Line 7: Log if timed out during fileSD.scanDomains().
Line 8:
Line 9: git gr -i -E 'sd.*?\.produce\('
I take this to mean "there are too many produce()s, which makes
fileSD.scanDomains() prone to Timouts, we should log it now, and avoid needless
procude()s in a future patch".
Line 10:
Line 11: Change-Id: I3af60f17b060d58c87260c744aecad21375cc25d
--
To view, visit http://gerrit.ovirt.org/8498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3af60f17b060d58c87260c744aecad21375cc25d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
