Nir Soffer has posted comments on this change. Change subject: monitor: Separate path status and domain status ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/57429/3/tests/storage_monitor_test.py File tests/storage_monitor_test.py: Line 70: def test_path_error_non_actual_domain_status(self): Line 71: path_status = monitor.PathStatus(error=Exception("path")) Line 72: domain_status = monitor.DomainStatus(actual=False) Line 73: status = monitor.Status(path_status, domain_status) Line 74: self.assertTrue(status.actual) > ok makes sense. Does this deserve a comment somewhere? I'll add a comment in actual property. Line 75: self.assertEqual(status.error, path_status.error) Line 76: self.assertFalse(status.valid) Line 77: Line 78: def test_domain_error(self): -- To view, visit https://gerrit.ovirt.org/57429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97e18ebec36b421d0b4ec20e768fe661d6facf98 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
