Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator ......................................................................
Patch Set 29: (1 comment) https://gerrit.ovirt.org/#/c/53214/28/lib/vdsm/Makefile.am File lib/vdsm/Makefile.am: Line 42: kaxmlrpclib.py \ Line 43: libvirtconnection.py \ Line 44: logUtils.py \ Line 45: m2cutils.py \ Line 46: machinetype.py \ > module names are typically one word or combined words. How about moduleload Done Line 47: moduleloader.py \ Line 48: momIF.py \ Line 49: numa.py \ Line 50: osinfo.py \ -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
