Dan Kenigsberg has posted comments on this change. Change subject: dhclient: consider NetworkManager lease files for DUID too ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/57151/2/lib/vdsm/network/configurators/dhclient.py File lib/vdsm/network/configurators/dhclient.py: Line 154: lease_file_names = [LEASE_FILE.format(dhclient_suffix, device_name)] Line 155: lease_file_names.extend( Line 156: iglob(NM_LEASE_FILE_GLOB.format(dhclient_suffix, device_name))) Line 157: dated_lease_file_names = [] Line 158: for name in lease_file_names: define a helper function, and use max(key=) to find the newest file Line 159: try: Line 160: modified_date = os.stat(name).st_mtime Line 161: except OSError as e: Line 162: if e.errno == errno.ENOENT: -- To view, visit https://gerrit.ovirt.org/57151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62a102a2964ed5e5864ff516c71752a23c4c55cf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
