Petr Balogh has uploaded a new change for review. Change subject: code coverage: add coverage for supervdsmServer ......................................................................
code coverage: add coverage for supervdsmServer In our QE jobs we would like to see also coverage report for supervdsm. I found out that there are missing lot of coverage, because if we run coverage in vdsm, it's not enough for cover all code/subprocess which vdsm/supervdsm runs. Regarding to [1], I moved coverage into sitecustomize.py which give us more accurate coverage reports. [1] http://coverage.readthedocs.io/en/coverage-4.0.3/subprocess.html?highlight=sitecustomize Signed-off-by: Petr Balogh <pbal...@redhat.com> Change-Id: I6a0c30177f238154b34513f83b7914d1783fd418 --- M vdsm/sitecustomize.py M vdsm/vdsm 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/57547/1 diff --git a/vdsm/sitecustomize.py b/vdsm/sitecustomize.py index d698a8b..a10f49e 100644 --- a/vdsm/sitecustomize.py +++ b/vdsm/sitecustomize.py @@ -1,5 +1,10 @@ import sys +from vdsm.config import config if sys.version_info[0] == 2: # Allow mixing of unicode objects and strings encoded in utf8. sys.setdefaultencoding('utf8') + +if config.getboolean('devel', 'coverage_enable'): + import coverage + coverage.process_startup() diff --git a/vdsm/vdsm b/vdsm/vdsm index 2090e01..bd714e9 100755 --- a/vdsm/vdsm +++ b/vdsm/vdsm @@ -128,11 +128,6 @@ logging.addLevelName(5, 'TRACE') logging.TRACE = 5 # impolite but helpful - - if config.getboolean('devel', 'coverage_enable'): - import coverage - coverage.process_startup() - log = logging.getLogger('vds') try: logging.root.handlers.append(logging.StreamHandler()) -- To view, visit https://gerrit.ovirt.org/57547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a0c30177f238154b34513f83b7914d1783fd418 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Balogh <pbal...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
