Zhou Zheng Sheng has posted comments on this change.
Change subject: No need to call receive if send is timeout
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/remoteFileHandler.py
Line 178: self._sendAll(request, timeout)
Line 179: except:
Line 180: self.log.warn("Problem with handler send, treating as
timeout",
Line 181: exc_info=True)
Line 182: raise Timeout()
We could consolidate the send operations into the following "try" statement. I
do not find difference on timeout handling logic between the added "try" and
the following try.
Even without the added "try", the execution of the function will not continue
when "Timeout" or other exception is raised from "self._sendAll()".
Line 183:
Line 184: try:
Line 185: rawLength = self._recvAll(LENGTH_STRUCT_LENGTH, timeout)
Line 186:
--
To view, visit http://gerrit.ovirt.org/7759
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib233b24d108a986d2f9e07a66f2a8f7d8cfb221a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
