Piotr Kliczewski has posted comments on this change. Change subject: yml: return type fixes for Host.getStats ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/57618/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 1759: Domain has been acquired and therefore if it's possible Line 1760: to run (sanlock) protected VMs Line 1761: name: acquired Line 1762: type: boolean Line 1763: > spurious whitespace (here and until line 1789) I forgot about dividing properties for when pushing it first time. Line 1764: - description: Indicates if the returned status is an actual Line 1765: monitoring result or initial result that means that Line 1766: the first monitor run was not yet completed Line 1767: name: actual PS2, Line 2018: haStats > surely useful, but related? Yes, we send this name instead of "haStatus" :/ PS2, Line 2050: - description: Indicates whether ksm merge is enabled : name: ksmMergeAcrossNodes : type: boolean > useful, but related? Verification code complained about this param missing. We send it so I added it to the schema. -- To view, visit https://gerrit.ovirt.org/57618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87eb9c45371fd1c99d5d1a6645ebf51e2ab1e439 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
