Francesco Romani has posted comments on this change. Change subject: yml: return type fixes for Host.getCapabilities ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/57623/3/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS3, Line 5365: glusterfs-cli: Interesting that we report it > I noticed it in the response and I decided to add here. Why do we send it I I'd just use "GlusterFS CLI" aka rpm -qi glisterfs-cli | grep Summary PS3, Line 5367: librbd1: New interesting software package > As above. I'd use "RADOS block device client library" PS3, Line 5383: long > I added it because for most of package infos we send it as long. I am open the name is fine, I was just surprised we need to differentiate between 'int' and 'long'. https://gerrit.ovirt.org/#/c/57623/3/lib/api/vdsmapi.py File lib/api/vdsmapi.py: PS3, Line 36: float > for the kernel we send float: lovely indeed. Ok then, let's fix this in a different patch. -- To view, visit https://gerrit.ovirt.org/57623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a6d630a63b3ca83edd3fbf0774e017db57d0d05 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
