Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py File vdsm/virt/migration.py: PS11, Line 647: self._vm.log.info('%s', prog) > Here "prog" is an instance of the "Progress" class, see line 714 below. Okay, saw the line above and though that it's the prog. Quite confusing to have both, I'd prefer self.progress to be the instance of the class calling directly percentage when you're accessing it. -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
