Francesco Romani has posted comments on this change. Change subject: migration: use composition in DowntimeThread ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG Commit Message: PS4, Line 9: It is bad practice to inherit from threading.Thread. > Why? because we should prefer composition over inheritance. -- To view, visit https://gerrit.ovirt.org/56687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3778a54489f0bb8f21120102779dfcd37b3859a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
