Francesco Romani has uploaded a new change for review.

Change subject: schema: use datatype to silence inconsistencies
......................................................................

schema: use datatype to silence inconsistencies

Make use of datatype/type annotations to silence
_report_inconsistencies and at least document those
inconsistencies.
We cannot really fix this until we fix the Engine side,
for backward compatibility.

Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Signed-off-by: Francesco Romani <from...@redhat.com>
---
M lib/api/vdsm-api.yml
1 file changed, 72 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/59258/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index b537e8e..a2ae77f 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -3851,7 +3851,8 @@
             description: Enables hyperv specific optimizations for the Guest
                 OS
             name: hypervEnable
-            type: boolean
+            datatype: boolean
+            type: string
             added: '3.5'
 
         -   defaultvalue: needs updating
@@ -3867,11 +3868,13 @@
 
         -   description: The amount of memory assigned to the VM in MB
             name: memSize
-            type: uint
+            datatype: uint
+            type: string
 
         -   description: The number of CPUs presented to the VM
             name: smp
-            type: uint
+            datatype: uint
+            type: string
 
         -   defaultvalue: 16
             description: Maximum number of memory slots available This is
@@ -3890,7 +3893,8 @@
             description: Specify if file transfer is enabled. Currently
                 relevant for qxl devices only.
             name: fileTransferEnable
-            type: boolean
+            datatype: boolean
+            type: string
             added: '3.6'
 
         -   defaultvalue: pc
@@ -3900,41 +3904,48 @@
 
         -   description: Indicates if KVM hardware acceleration is enabled
             name: kvmEnable
-            type: boolean
+            datatype: boolean
+            type: string
 
         -   description: Indicates if the Transparent Huge Pages feature is
                 enabled for this virtual machine
             name: transparentHugePages
-            type: boolean
+            datatype: boolean
+            type: string
 
         -   description: The VM name
             name: vmName
             type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: no-default
             description: The num of iothreads qemu allocates
             name: numOfIoThreads
-            type: uint
+            datatype: uint
+            type: string
 
         -   description: The time difference from host to the VM in seconds
             name: timeOffset
-            type: uint
+            datatype: uint
+            type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: no-default
             description: The port in use for unencrypted display data
             name: displayPort
-            type: int
+            datatype: int
+            type: string
             modified: '3.6'
 
         -   description: The host scheduling priority
             name: nice
-            type: int
+            datatype: int
+            type: string
 
         -   description: The process ID of the underlying qemu process
             name: pid
-            type: uint
+            datatype: uint
+            type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: no-default
             description: Indicates the reason a VM has been paused
             name: pauseCode
             type: string
@@ -3948,30 +3959,34 @@
 
         -   description: Indicates if ACPI is enabled inside the VM
             name: acpiEnable
-            type: boolean
+            datatype: boolean
+            type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: no-default
             description: The port in use for encrypted display data
             name: displaySecurePort
-            type: int
+            datatype: int
+            type: string
             modified: '3.6'
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: no-default
             description: The maximum amount of memory that can be assigned
                 to the VM in MB
             name: maxMemSize
-            type: uint
+            datatype: uint
+            type: string
 
         -   description: The IP address of the client connected to the display
             name: clientIp
             type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: 1
             description: Indicates the number of CPU threads per core
             name: smpThreadsPerCore
-            type: uint
+            datatype: uint
+            type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: no-default
             description: The keyboard layout string (eg. 'en-us')
             name: keyboardLayout
             type: string
@@ -3983,13 +3998,15 @@
         -   defaultvalue: 1
             description: Indicates the number of CPU cores per socket
             name: smpCoresPerSocket
-            type: uint
+            datatype: uint
+            type: string
 
         -   defaultvalue: 1
             description: Maximum number of CPU available for the guest It
                 is the upper boundry for hot plug CPU action
             name: maxVCpus
-            type: uint
+            datatype: uint
+            type: string
 
         -   description: A comma-separated list of NIC models in use by the
                 VM
@@ -4003,20 +4020,21 @@
             name: cpuType
             type: string
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: ''
             description: The IP address to use for accessing the VM display
             name: displayIp
             type: string
             modified: '3.6'
 
-        -   defaultvalue: needs updating
+        -   defaultvalue: null
             description: Explains the reason that the VM process has exited
             name: exitMessage
             type: string
 
         -   description: The amount of memory guaranteed to the VM in MB
             name: memGuaranteedSize
-            type: uint
+            datatype: uint
+            type: string
 
         -   defaultvalue: needs updating
             description: Serial number for the VM.
@@ -4027,13 +4045,15 @@
             description: Specify if copy and paste is enabled. Currently
                 relevant for qxl devices only.
             name: copyPasteEnable
-            type: boolean
+            datatype: boolean
+            type: string
             added: '3.4'
 
         -   defaultvalue: null
             description: The exit code f the VM process has ended
             name: exitCode
-            type: int
+            datatype: int
+            type: string
 
         -   description: The current VM status
             name: status
@@ -6483,7 +6503,8 @@
             description: Enables hyperv specific optimizations for the Guest
                 OS.
             name: hypervEnable
-            type: boolean
+            datatype: boolean
+            type: string
             added: '3.5'
 
         -   defaultvalue: no-default
@@ -6495,20 +6516,24 @@
         -   defaultvalue: no-default
             description: If present, launch the VM in pause mode.
             name: launchPaused
-            type: boolean
+            datatype: boolean
+            type: string
 
         -   description: The amount of memory assigned to the VM in MB
             name: memSize
-            type: uint
+            datatype: uint
+            type: string
 
         -   defaultvalue: 1
             description: Indicates the number of CPU threads per core
             name: smpThreadsPerCore
-            type: uint
+            datatype: uint
+            type: string
 
         -   description: The number of CPUs presented to the VM
             name: smp
-            type: uint
+            datatype: uint
+            type: string
 
         -   defaultvalue: no-default
             description: Indicates the guest numa topology.
@@ -6523,6 +6548,7 @@
         -   defaultvalue: false
             description: enable the BIOS boot menu
             name: bootMenuEnable
+            datatype: boolean
             type: boolean
             added: '3.4'
 
@@ -6539,12 +6565,14 @@
 
         -   description: Indicates if KVM hardware acceleration is enabled
             name: kvmEnable
-            type: boolean
+            datatype: boolean
+            type: string
 
         -   description: Indicates if the Transparent Huge Pages feature is
                 enabled for this virtual machine
             name: transparentHugePages
-            type: boolean
+            datatype: boolean
+            type: string
 
         -   description: The VM name
             name: vmName
@@ -6552,11 +6580,13 @@
 
         -   description: The time difference from host to the VM in seconds
             name: timeOffset
-            type: uint
+            datatype: uint
+            type: string
 
         -   description: The host scheduling priority
             name: nice
-            type: int
+            datatype: int
+            type: string
 
         -   defaultvalue: null
             description: Indicates the numatune configuration.
@@ -6566,7 +6596,8 @@
         -   defaultvalue: 1
             description: Indicates the number of CPU cores per socket
             name: smpCoresPerSocket
-            type: uint
+            datatype: uint
+            type: string
 
         -   defaultvalue: null
             description: The host scheduling priority (relative to other VMs).
@@ -6577,7 +6608,8 @@
 
         -   description: Indicates if ACPI is enabled inside the VM
             name: acpiEnable
-            type: boolean
+            datatype: boolean
+            type: string
 
         -   description: The type of VM
             name: vmType


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to