Edward Haas has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/58970/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 409: self.assertEqual(netinfo.bondings[bondName]['active_slave'], '') Line 410: Line 411: def setupNetworks(self, networks, bonds, options, **kwargs): Line 412: test_kernel_config = kwargs.pop('test_kernel_config', True) Line 413: switch = os.environ.get('VDSM_TESTER_SWITCH_TYPE') > we can initialize this on module/class-level Not sure it is worth it, it does not seem to cost anything. I used memoized, the class level fixture is somehow colliding with monkeypatches. Line 414: if switch: Line 415: for net, attrs in networks.items(): Line 416: tested_switch = attrs.get('switch') Line 417: if tested_switch != switch: Line 412: test_kernel_config = kwargs.pop('test_kernel_config', True) Line 413: switch = os.environ.get('VDSM_TESTER_SWITCH_TYPE') Line 414: if switch: Line 415: for net, attrs in networks.items(): Line 416: tested_switch = attrs.get('switch') > i think we have to add default value 'legacy' Yea, I did in patch3. Line 417: if tested_switch != switch: Line 418: raise SkipTest('{} switch tests'.format(tested_switch)) Line 419: status, msg = self.vdsm_net.setupNetworks(networks, bonds, options) Line 420: unified = ( -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
