Michal Skrivanek has posted comments on this change. Change subject: rpc: Log important info from VM stats ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py File vdsm/API.py: Line 1344: """ Line 1345: hooks.before_get_all_vm_stats() Line 1346: statsList = self._cif.getAllVmStats() Line 1347: statsList = hooks.after_get_all_vm_stats(statsList) Line 1348: self._allvmstats_log.log(self.log, logging.DEBUG, > Probably because the hook can modify statsList indeed. that's the purpose of that hook. We have similar issue in e.g. create flow where hooks are often modifying the domain xml heavily, so we dump it right before sending to libvirt Line 1349: "Current getAllVmStats: %s", Line 1350: AllVmStatsValue(statsList)) Line 1351: return {'status': doneCode, 'statsList': Suppressed(statsList)} Line 1352: -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
