Milan Zamazal has posted comments on this change. Change subject: api: Move after_get_all_vm_stats hook from API to clientIF ......................................................................
Patch Set 1: > Let's have both hooks in the same place. I think there's no disagreement about that. What's more important is whether we should move the hooks and put logging into clientIF.py, or whether it's better to not touch the hooks and put logging into API.py. What do you think Piotr, considering Nir's comment? -- To view, visit https://gerrit.ovirt.org/59393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9cdf57e7fc4e72733b195acdd84a10602df7ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
