Irit Goihman has uploaded a new change for review.
Change subject: tox: added disable tox style validation option to Makefile
......................................................................
tox: added disable tox style validation option to Makefile
This patch adds DISABLE_STYLE_VALIDATION which is an environment
variable that disables tox run.
This option is useful for developers who encounter issues running tox
on their environment and want to skip tox style validation.
use it by the following:
make check DISABLE_STYLE_VALIDATION=1
Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Signed-off-by: Irit Goihman <igoih...@redhat.com>
---
M Makefile.am
1 file changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/59417/1
diff --git a/Makefile.am b/Makefile.am
index 9ac2515..9d43d58 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -81,18 +81,26 @@
.PHONY: pyflakes
pyflakes:
- if [ -n "$(TOX)" ]; then \
- tox -- pyflakes; \
+ if [ "$(DISABLE_STYLE_VALIDATION)" == "1" ]; then \
+ echo "Warning: style validation disabled, skipping check"; \
else \
- echo "Warning: tox is not installed, skipping check"; \
- fi
+ if [ -n "$(TOX)" ]; then \
+ tox -- pyflakes; \
+ else \
+ echo "Warning: tox is not installed, skipping check"; \
+ fi \
+ fi
.PHONY: pep8
pep8:
- if [ -n "$(TOX)" ]; then \
- tox -- pep8; \
+ if [ "$(DISABLE_STYLE_VALIDATION)" == "1" ]; then \
+ echo "Warning: style validation disabled, skipping check"; \
else \
- echo "Warning: tox is not installed, skipping check"; \
+ if [ -n "$(TOX)" ]; then \
+ tox -- pep8; \
+ else \
+ echo "Warning: tox is not installed, skipping check"; \
+ fi \
fi
.PHONY: python3
--
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
