Royce Lv has posted comments on this change. Change subject: Implement a zombie reaper ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/zombieReaper.py Line 9: # SIGCHLD happend before we added the pid to the set Line 10: _tryReap(pid) Line 11: Line 12: Line 13: def _tryReap(pid): Why not using Popen.poll() instead of this function? Line 14: try: Line 15: pid, rv = os.waitpid(pid, os.WNOHANG) Line 16: if pid != 0: Line 17: _trackedPids.discard(pid) -- To view, visit http://gerrit.ovirt.org/8937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fdf96e195135284b2733b21f611918ffbf69791 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Peter Portante <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
