Dan Kenigsberg has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/58970/8//COMMIT_MSG Commit Message: Line 8: Line 9: Use VDSM_TESTER_SWITCH_TYPE env variable to specify which switch type Line 10: should be tested in the functional tests. Line 11: If it is not set, all switch types will run. Line 12: If 'ovs' (or 'legacy') is set, then 'legacy' (or 'ovs') are skipped. please refer to the ovs(?) bug forcing us to do this trick. Line 13: Line 14: Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 https://gerrit.ovirt.org/#/c/58970/8/tests/functional/networkTests.py File tests/functional/networkTests.py: PS8, Line 425: _skip_per_switch_type maybe _skip_nontested_switch()? or add the docstring """skip setupNetwork if it attempts to create a switchtype other than VDSM_TESTER_SWITCH_TYPE' -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
