Nir Soffer has posted comments on this change. Change subject: rpc: Log important info from VM stats ......................................................................
Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/58465/20/vdsm/clientIF.py File vdsm/clientIF.py: Line 442 Line 443 Line 444 Line 445 Line 446 This is a good pattern for other verbs: - We control what we log using wrappers - We control when we log using throtteldlog Line 89: if self.irs: Line 90: self._contEIOVmsCB = partial(clientIF.contEIOVms, proxy(self)) Line 91: self.irs.registerDomainStateChangeCallback(self._contEIOVmsCB) Line 92: self.log = log Line 93: throttledlog.throttle('getAllVmStats', 40) Better move this to _configure_logging() helper, this method is already too big. Line 94: self._recovery = True Line 95: self.channelListener = Listener(self.log) Line 96: self.mom = None Line 97: self.bindings = {} -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
