Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59308/3/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in: Line 35: 'version_name': version_name, Line 36: 'software_version': software_version, Line 37: 'software_revision': software_revision, Line 38: 'supportedENGINEs': ['3.5', '3.6', '4.0', '4.1'], Line 39: 'clusterLevels': ['3.5','3.6', '4.0', '4.1'], > You are missing space before '3.6' and have a redundant space after it. Done Line 40: } Line 41: Line 42: if cpuarch.real() == cpuarch.PPC64LE: -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
