Piotr Kliczewski has uploaded a new change for review. Change subject: api: unexpected response when a verb returns nothing ......................................................................
api: unexpected response when a verb returns nothing We used to send True for verbs where there is no response. Now we send None which causes NPE in the engine when parsing StorageDomain.activate response. This patch fixes this regression. Change-Id: I5630052bea05fb8ea4fa3f2ff1dfedf6e1b2841d Signed-off-by: Piotr Kliczewski <[email protected]> --- M lib/yajsonrpc/__init__.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/59469/1 diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 6d85fe2..3775fc3 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -540,6 +540,7 @@ JsonRpcInternalError(str(e)), req.id)) else: + res = True if res is None else res self.log.log(logLevel, "Return '%s' in bridge with %s", req.method, res) if isinstance(res, Suppressed): -- To view, visit https://gerrit.ovirt.org/59469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5630052bea05fb8ea4fa3f2ff1dfedf6e1b2841d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
