Nir Soffer has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py File client/vdsClient.py: Line 1386: if status['status']['code']: Line 1387: return status['status']['code'], status['status']['message'] Line 1388: return 0, status['uuid'] Line 1389: Line 1390: def sparsifyImageInplace(self, args): > We may want to have it for now. This method is not enough to add new verb s Why add support in this deprecated client when we are not going to support it in bingindxmlrpc.py? Line 1391: (imgUUID, spUUID, sdUUID, volUUID) = args Line 1392: status = self.s.sparsifyImageInplace(imgUUID, spUUID, sdUUID, volUUID) Line 1393: if status['status']['code']: Line 1394: return status['status']['code'], status['status']['message'] -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
