Edward Haas has posted comments on this change. Change subject: net virt: Support connecting VM/s to an ovs bridge ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/57508/6/tests/deviceTests.py File tests/deviceTests.py: PS6, Line 430: ovirtmgmt > we should pass something else here to test if MockedProxy.ovs_bridge() was Sorry, I do not follow. Obviously it is used, otherwise I would not need to mock getProxy and the expected result (interfaceXML) would not match actual. -- To view, visit https://gerrit.ovirt.org/57508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id233c3b46f0d3a546d1524456fc681d16873ad50 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
