Piotr Kliczewski has posted comments on this change. Change subject: API: streamline and make setLogLevel correct ......................................................................
Patch Set 15: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/38425/15/vdsm/API.py File vdsm/API.py: PS15, Line 1380: 'unavail' > 'unavail' does not fit here, I'd rather not handle the exception at all. I am not sure whether returning internal server error is better. It would be returned if unexpected error is handled by rpc code. What about value error code here? -- To view, visit https://gerrit.ovirt.org/38425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
