Piotr Kliczewski has posted comments on this change.

Change subject: logging: throttledlog introduced
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/59461/3//COMMIT_MSG
Commit Message:

PS3, Line 9:   
Why 2 spaces in few places in this message?


https://gerrit.ovirt.org/#/c/59461/3/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py:

PS3, Line 27: _DEFAULT_TIMEOUT_SEC
Is there any value in making it configurable?


-- 
To view, visit https://gerrit.ovirt.org/59461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief96f74eb84880827ccf24c3e7ae854403090b8a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to