Piotr Kliczewski has posted comments on this change. Change subject: rpc: Log RPC call summary on info level ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/59080/12/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 507: req.method, monotonic_time() - start_time) Line 508: if response is not None: Line 509: ctx.requestDone(response) Line 510: Line 511: def _handle_request(self, ctx, req): > Good idea, but do we really need the server address? I think this was a hac We were using it for getCaps and lastClient details. I think that we would still need it. Dan? Line 512: self._attempt_log_stats() Line 513: logLevel = logging.DEBUG Line 514: Line 515: # VDSM should never respond to any request before all information about -- To view, visit https://gerrit.ovirt.org/59080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
