Francesco Romani has submitted this change and it was merged. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response ......................................................................
jsonrpc: Pass JsonRpcInternalError instance, not class, to response If there is a problem with processing a response in _JsonRpcServeRequestContext.sendReply, the method generates a general error response. However, due to missing parentheses, JsonRpcInternalError class, instead of JsonRpcInternalError instance, is passed as `error' argument to JsonRpcResponse. This leads to a crash when JsonRpcResponse tries to access `error'. This patch fixes the error by adding the missing parentheses. Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a Signed-off-by: Milan Zamazal <[email protected]> Backport-To: 4.0 Backport-To: 3.6 Reviewed-on: https://gerrit.ovirt.org/59355 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-on: https://gerrit.ovirt.org/59554 Reviewed-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/59595 --- M lib/yajsonrpc/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/59595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c3d4065374d739bbecdbe4c17d7e513153c034a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
