Edward Haas has posted comments on this change. Change subject: net func test: test network based on a vlan ......................................................................
Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/59622/2/tests/network/func_net_basic_test.py File tests/network/func_net_basic_test.py: PS2, Line 64: '{}.{}'.format(nic, VLAN) How the VLAN is represented is an implementation detail, better pass here the nic and VLAN as arguments, format it in the assert itself. https://gerrit.ovirt.org/#/c/59622/2/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: PS2, Line 175: assertNoVlanExists Isn't this the negative of assertVlan? (assertNoVlan) -- To view, visit https://gerrit.ovirt.org/59622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I654af5a81518c2b51ac8694b1ed307aad004a256 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
