Irit Goihman has posted comments on this change. Change subject: infra: moved infra package contents from lib/vdsm to lib/vdsm/common ......................................................................
Patch Set 6: (7 comments) https://gerrit.ovirt.org/#/c/59304/5//COMMIT_MSG Commit Message: Line 6: Line 7: infra: moved infra package contents from lib/vdsm to lib/vdsm/common Line 8: Line 9: infra package was under lib/vdsm/infra with a few sub packages. Line 10: every package was converted to module and replaced under lib/vdsm/common > and as part of that we also remove the vdsm-infra package as its redundant Done Line 11: vdsm-infra package was also removed from vdsm.spec.in as it was redundant Line 12: and there is no use for it right now. Line 13: Line 14: Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6 https://gerrit.ovirt.org/#/c/59304/5/lib/vdsm/common/sigutils.py File lib/vdsm/common/sigutils.py: Line 23: import os Line 24: import select Line 25: import signal Line 26: Line 27: from vdsm.common import filecontrol > why not keeping it absolute ? Done Line 28: Line 29: _signal_poller = None Line 30: _signal_read_fd = None Line 31: https://gerrit.ovirt.org/#/c/59304/5/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 22: Line 23: import logging Line 24: import socket Line 25: Line 26: from vdsm.common import filecontrol > from vdsm.common import filecontrol .. Done Line 27: from vdsm.utils import monotonic_time Line 28: from vdsm.sslcompat import SSLHandshakeDispatcher Line 29: Line 30: https://gerrit.ovirt.org/#/c/59304/5/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 39: import zipfile Line 40: Line 41: import libvirt Line 42: Line 43: from vdsm.commands import execCmd > should be here I guess Done Line 44: from vdsm.common import zombiereaper Line 45: from vdsm.constants import P_VDSM_RUN, EXT_KVM_2_OVIRT Line 46: from vdsm.define import errCode, doneCode Line 47: from vdsm import libvirtconnection, response, concurrent https://gerrit.ovirt.org/#/c/59304/5/tests/eventfd_test.py File tests/eventfd_test.py: Line 19: # Line 20: from __future__ import absolute_import Line 21: import fcntl Line 22: from nose import tools Line 23: from testlib import VdsmTestCase > should be under external imports Done Line 24: Line 25: from vdsm.common import eventfd Line 26: Line 27: class TestEventFD(VdsmTestCase): https://gerrit.ovirt.org/#/c/59304/5/tests/testrunner.py File tests/testrunner.py: Line 34: # Python 2.6 does not have captureWarnings, though luck Line 35: logging.captureWarnings(True) Line 36: Line 37: Line 38: from vdsm.common import zombiereaper > from vdsm.common inmport zombiereaper Done Line 39: zombiereaper.registerSignalHandler() Line 40: Line 41: from vdsm import panic Line 42: import testlib https://gerrit.ovirt.org/#/c/59304/5/tests/zombiereaper_test.py File tests/zombiereaper_test.py: Line 20: from __future__ import absolute_import Line 21: from time import sleep Line 22: import os Line 23: Line 24: from subprocess import Popen > under stdlib imports Done Line 25: from testlib import VdsmTestCase Line 26: Line 27: from vdsm.common import zombiereaper Line 28: -- To view, visit https://gerrit.ovirt.org/59304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
