Piotr Kliczewski has posted comments on this change. Change subject: yml: generate api doc from the schema ......................................................................
Patch Set 24: (2 comments) https://gerrit.ovirt.org/#/c/56387/24/lib/api/vdsmapi.py File lib/api/vdsmapi.py: Line 156: return self._methods[rep.id] Line 157: except KeyError: Line 158: raise MethodNotFound(rep.id) Line 159: Line 160: def get_all_methods(self): > Looking at the other apis, I'm not sure it is better, this is very consiste Done Line 161: return self._methods Line 162: Line 163: def get_type(self, type_name): Line 164: try: Line 165: return self._types[type_name] Line 166: except KeyError: Line 167: raise TypeNotFound(type_name) Line 168: Line 169: def get_all_types(self): > Same as above, need to copy the _types dict. Done Line 170: return self._types Line 171: Line 172: def _check_primitive_type(self, t, value, name): Line 173: condition = PRIMITIVE_TYPES.get(t) -- To view, visit https://gerrit.ovirt.org/56387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
