Yaniv Bronhaim has posted comments on this change. Change subject: tox: Exclude .ropeproject from pep8 check ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59677/2/tox.sh File tox.sh: Line 25: Line 26: if [ 'pyflakes' = "$1" ]; then Line 27: (find . -path './.tox' -prune -type f -o \ Line 28: -path './.git' -prune -type f -o \ Line 29: -name '*.py' && echo "${WHITELIST[@]}") | \ does it pass pyflakes check? maybe we should omit all .(hidden) dirs, but we should do it also for pyflakes and maybe add doc string that mention that here Line 30: xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \ Line 31: while read LINE; do echo "$LINE"; false; done Line 32: fi Line 33: -- To view, visit https://gerrit.ovirt.org/59677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09029b6209195d11e6013f776011f6565ab950d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
