Yaniv Bronhaim has posted comments on this change. Change subject: Another missing of joinAll after using ThreadPool ......................................................................
Patch Set 1: Nobody died of two calls to joinAll. I saw the stop function and still I prefer that the cleaning will be in the finally scope to be sure that it will really happen, instead of in stop (like you did in SPM_mailbox) it will help to prevent bugs like adding another 'stop' function that won't call to joinAll, or if someone will externally change self.stop to false. But if you trust that nobody will ruin it, so although you have leaks I'm with you -- To view, visit http://gerrit.ovirt.org/9009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207d8db5863e11e89394b9144600b625282c51b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
