Petr Horáček has posted comments on this change. Change subject: netswitch: split setup actions on netswitch level ......................................................................
Patch Set 18: Verified+1 (2 comments) New func_ tests and netswitch test passed OK. https://gerrit.ovirt.org/#/c/58502/10/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS10, Line 187: > It's enough, but it's not consistent. I would expect the split func to retu Done https://gerrit.ovirt.org/#/c/58502/10/tests/network/netswitch_test.py File tests/network/netswitch_test.py: PS10, Line 36: _split_setup_actions > Unfortunate, it is not in yet. We have to call netswitch.py:setup() from here and mock ovs/switch.py:setup(). With that we will test not only _split_setup_actions, but also _split_switch_type and more stuff on the way. I'd like to postpone it and fix later (hopefully with mock) -- To view, visit https://gerrit.ovirt.org/58502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
