Edward Haas has posted comments on this change. Change subject: net: disable unused IPv6 in ip.address.add() ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/59002/6/lib/vdsm/network/ip/address.py File lib/vdsm/network/ip/address.py: Line 183: if ipv6.address: Line 184: ipv6addr, ipv6netmask = ipv6.address.split('/') Line 185: ipwrapper.addrAdd(iface, ipv6addr, ipv6netmask, family=6) Line 186: if ipv6.gateway: Line 187: ipwrapper.routeAdd(['default', 'via', ipv6.gateway], > But this function is also used by iproute2 which does not guarantee that. M I do not understand your argument here. The iproute2 configurator was not used in production, if there is a bug in the logic there, we should not drag it. Could you please explain the reason for doing this check before usage (setting IP) and not after creation (of iface)? And _wait_for_device itself does not belong here, it is link related, which hints about the problem. Line 188: dev=iface, family=6) Line 189: if ipv6.ipv6autoconf is not None: Line 190: with open('/proc/sys/net/ipv6/conf/%s/autoconf' % iface, Line 191: 'w') as ipv6_autoconf: -- To view, visit https://gerrit.ovirt.org/59002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ea45e23f5a331cbb205cbb40f96dc3b4bc92958 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
