Nir Soffer has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
......................................................................


Patch Set 22:

(1 comment)

https://gerrit.ovirt.org/#/c/58728/22/tests/config_test.py
File tests/config_test.py:

Line 137: 
Line 138:             cfg = config.load('vdsm')
Line 139:             self.assertEqual(cfg.getint('test', 'num'), 53)
Line 140: 
Line 141:     def test_not_deleted(self):
Let make the name match the description of the test.
Line 142:         """
Line 143:         make sure unrelated items were not modified by reading default
Line 144:         values, creating new conf files, running config.load and 
checking
Line 145:         the options still exist in ConfigParser


-- 
To view, visit https://gerrit.ovirt.org/58728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to