Dan Kenigsberg has posted comments on this change.
Change subject: pep8 now also check visual aligment
......................................................................
Patch Set 3: Verified; Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1154: if func is None:
Line 1155: continue
Line 1156: try:
Line 1157: self._log.debug("Calling registered method `%s`",
Line 1158: logUtils.funcName(func))
Ok, I can take this, in a pep8 fix.
Line 1159: if self._sync:
Line 1160: func(*args, **kwargs)
Line 1161: else:
Line 1162: threading.Thread(target=func, args=args,
--
To view, visit http://gerrit.ovirt.org/9038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27f420e173eec667a8f81e8bdd13a4bd98bf200
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
