Francesco Romani has submitted this change and it was merged. Change subject: Introduce reports package ......................................................................
Introduce reports package reports logic allows to send report to external providers by start close and send functions. The report itself is simply key value attribute. This patch includes statsd reporter which implements the send method to statsd listener by python-statsd. To enable reports add the following to vdsm.conf: [reports] enabled = false|true (disabled by default) collector_type = statsd (following patch adds more providers) collector_address = localhost|any hostname (currently one destination) We still miss python-stastd for python3 so we don't require the package in spec. If metric collector is configured to be enable and the type implementation is not available ImportError should be raised. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1350350 Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9 Signed-off-by: Yaniv Bronhaim <[email protected]> Reviewed-on: https://gerrit.ovirt.org/56880 Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Martin Polednik <[email protected]> Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/59772 Reviewed-by: Francesco Romani <[email protected]> --- M configure.ac M lib/vdsm/Makefile.am M lib/vdsm/config.py.in A lib/vdsm/reports/Makefile.am A lib/vdsm/reports/__init__.py A lib/vdsm/reports/statsd.py M vdsm.spec.in M vdsm/vdsm 8 files changed, 130 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
