Eduardo has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 206: try:
Line 207: lvm.changelv(sdUUID, volUUIDs, (("-a", "y"), ("--deltag",
imgUUID),
Line 208: ("--addtag", sd.REMOVED_IMAGE_PREFIX +
imgUUID)))
Line 209: except se.StorageException as e:
Line 210: log.debug("SD %s, Image %s pre zeroing ops failed", sdUUID,
imgUUID,
If the activation failed the zeroing will fail shortly anyway. If the retagging
failed, anyway is worth to zeroing the volumes.
In the worst case a totally or partial blanked image will remain. Anyway the
user wanted to removed it anyway.
Line 211: volUUIDs)
Line 212: # Following call to changelv is separate since setting rw
permission on an
Line 213: # LV fails if the LV is already set to the same value, hence we
would not
Line 214: # be able to differentiate between a real failure of
deltag/addtag and one
--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
