Ayal Baron has posted comments on this change.
Change subject: Add callback to the plethora of retry halting possibilities
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File tests/miscTests.py
Line 633: return False
Line 634:
Line 635: def foo():
Line 636: print counter[0]
Line 637: if counter[0] == (limit - 1):
also, the test is needlessly confusing.
foo should not touch counter, only stopCallback should.
foo should always fail to keep it simple.
Line 638: return
Line 639:
Line 640: raise RuntimeError("If at first you don't succeed, try,
try again."
Line 641: "Then quit. There's no point in being
a damn"
--
To view, visit http://gerrit.ovirt.org/8093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb5a2158f008b41133352dcfb4926ad21dcceea1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
