Shu Ming has posted comments on this change. Change subject: Using only globalPool allow only 10 processes ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Also, see my concern about possibleDomain in line. .................................................... File vdsm/storage/fileSD.py Line 478: mntList = getMountsList(pattern) Line 479: Line 480: def collectMetaFiles(possibleDomain): Line 481: try: Line 482: metaFiles = oop.getProcessPool(possibleDomain).glob.glob( What is possibleDomain? From the itmap() call below, is it a possible path to be mounted? Line 483: os.path.join(possibleDomain, Line 484: constants.UUID_GLOB_PATTERN, Line 485: sd.DOMAIN_META_DATA)) Line 486: -- To view, visit http://gerrit.ovirt.org/9029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a4024b8d8be8b9cbbb4836987dfb94e3a11d7d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
