Vinzenz Feenstra has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59866/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 860: with self._confLock: Line 861: self.conf['clientIp'] = clientIp Line 862: self._clientPort = clientPort Line 863: Line 864: def _timedDesktopLock(self): > would @utils.traceback Well that's what I was discussing with Milan already - The question is if it will be now still beneficial, I have tested all scenarios and found this in the process. But I guess for future extension it's probably better to have, so I will add a follow up with that Line 865: # This is not a definite fix, we're aware that there is still the Line 866: # possibility of a race condition, however this covers more cases Line 867: # than before and a quick gain Line 868: if (not self.conf.get('clientIp', '') and -- To view, visit https://gerrit.ovirt.org/59866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b030d4a7a7ed7ad3f6279c66120d1f9e45d396 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
