Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/59875

to review the following change.

Change subject: API: doc: reformat docstring for consistency
......................................................................

API: doc: reformat docstring for consistency

Change-Id: I13e3b6e85ab6a935ec15e581fba9fecc02fc588b
Signed-off-by: Francesco Romani <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/59668
Reviewed-by: Dan Kenigsberg <[email protected]>
Continuous-Integration: Dan Kenigsberg <[email protected]>
---
M vdsm/API.py
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/59875/1

diff --git a/vdsm/API.py b/vdsm/API.py
index c38fbe9..67d3115 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1368,13 +1368,15 @@
     def setLogLevel(self, level, name=''):
         """
         Set verbosity level of vdsm's log.
+        Doesn't survive a restart.
 
-        params
-            level: requested logging level. `logging.DEBUG` `logging.ERROR`
-            name: logger name to set. If not provided, defaults to the root
-                  logger. Otherwise, tune the specific logger provided.
-
-        Doesn't survive a restart
+        :param level: requested logging level.
+                Examples: `logging.DEBUG` `logging.ERROR`
+        :type level: string
+        :param name: logger name to set. If not provided,
+                defaults to the root logger.
+                Otherwise, tune the specific logger provided.
+        :type name: string
         """
         logUtils.set_level(level, name)
         return dict(status=doneCode)


-- 
To view, visit https://gerrit.ovirt.org/59875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13e3b6e85ab6a935ec15e581fba9fecc02fc588b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to