Edward Haas has posted comments on this change. Change subject: tests: add mocking in deviceTests ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/59876/1/tests/deviceTests.py File tests/deviceTests.py: PS1, Line 611: _getNetworkIp It's not recommended to fake or test private funcs/methods. It causes over coupling between the tests and the productions code. I would suggest mocking the relevant networking api/s: net_api.libvirt_networks net_api.ip_addrs_info -- To view, visit https://gerrit.ovirt.org/59876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18ac1ea95c2f3c79feb348f2495854f79a650cb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
