Nir Soffer has posted comments on this change. Change subject: Makefile: added 'tests' target ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/59417/5//COMMIT_MSG Commit Message: Line 6: Line 7: Makefile: added 'tests' target Line 8: Line 9: during vdsm rpm check 'make check' is running style validation Line 10: using tox. pyflakes is not style validation, please avoid this wrong term, it matches only pep8. Line 11: not all machines support tox and there are some issues Line 12: running tox without network. Line 13: separating style validation from tests enables creating an rpm Line 14: without style check. Line 10: using tox. Line 11: not all machines support tox and there are some issues Line 12: running tox without network. Line 13: separating style validation from tests enables creating an rpm Line 14: without style check. Same here, don't mention style check. Line 15: Line 16: This patch adds tests as dependency to 'check' target. Also, during Line 17: rpm build only tests target will run without style validation. Line 18: -- To view, visit https://gerrit.ovirt.org/59417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
