Nir Soffer has submitted this change and it was merged. Change subject: periodic: Avoid useless drive monitoring ......................................................................
periodic: Avoid useless drive monitoring The periodic system is checking every 2 seconds if a vm is ready for commands (Vm.isDomainReadyForCommands). If a vm is ready, it schedules an extend task in the scheduler (Vm.extendDrivesIfNeeded). However, if a vm does not have any chunked drives (thin provisioned block storage), or is in the middle of live storage migration from non-chunked drive to chunked drive, extending drives is never needed. Checking if a vm is ready for commands should be safe, but recently libvirt fixed a bug that cause this check to get stuck. Now we check if a vm has chunked drives or non-chunked drives replicating to chunked drives in DriveWatermarkMonitor.required, skipping such vms early. This change saves one libvirt call per vm each 2 seconds, and running useless extend task per vm in the executor, reducing cpu usage when using file based storage. This also reduces the risk of uncontrolled executor worker discarding when NFS server become unresponsive. Change-Id: I274acc2112cd9b55ac1867d850401be8911adf29 Relates-To: https://bugzilla.redhat.com/1337073 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/59764 Continuous-Integration: Jenkins CI Reviewed-by: Milan Zamazal <[email protected]> Reviewed-by: Francesco Romani <[email protected]> --- M lib/vdsm/virt/periodic.py M vdsm/virt/vm.py 2 files changed, 20 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I274acc2112cd9b55ac1867d850401be8911adf29 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
