Nir Soffer has submitted this change and it was merged. Change subject: vm: Introduce drive monitoring concept ......................................................................
vm: Introduce drive monitoring concept We have two periodic operations related to monitoring drives; updating volume size and extending drives. Both are controlled by the strange concept of disks stats collection. Replace the concept of disk stats collection with the more general concept of drive monitoring. This is also a preparation for extracting the drive monitoring code to its own class. The old methods were mixing the concepts of running (start, stop) and enabling (enabled). The new methods use the enabling concept. The old methods stored the current state in self._volumesPrepared; this looks like a leftover from older implementation. Now we store the state in self._driveMonitorEnabled. Change-Id: Ia082f8bef03735c63b66e6b6c574e527bf6cafb4 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/59765 Reviewed-by: Milan Zamazal <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Continuous-Integration: Jenkins CI --- M lib/vdsm/virt/periodic.py M vdsm/virt/vm.py 2 files changed, 23 insertions(+), 23 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia082f8bef03735c63b66e6b6c574e527bf6cafb4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
