Amit Aviram has posted comments on this change. Change subject: qemuimg: Introduce supports_compat helper ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/59410/7/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: PS7, Line 52: _QCOW2_COMPAT_SUPPORTED I think you are verifying with the wrong value, this list is the versions that VDSM generally supports, while the version that the specific instance of VDSM runs is configured in: config.get('irs', 'qcow2_compat') See this change for reference: I8e217ec42a803d53403947a5fb140cb51202fbfa -- To view, visit https://gerrit.ovirt.org/59410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
