Dan Kenigsberg has posted comments on this change. Change subject: migration: usage of single reactor in vdsm ......................................................................
Patch Set 5: Code-Review+2 (1 comment) raising score, based on a promise for an upcoming unit test patch. https://gerrit.ovirt.org/#/c/59720/5/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: PS5, Line 467: owns_reactor=False I'd find it clearer if we do not have a default here, and have the in-vdsm users pass False explicitly, as they are the special case. Please consider. -- To view, visit https://gerrit.ovirt.org/59720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
