Petr Horáček has posted comments on this change. Change subject: ovs: move bridges cleanup to a separate function ......................................................................
Patch Set 3: Verified+1 (1 comment) Passed func_*_test.py OK. https://gerrit.ovirt.org/#/c/59903/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 154: nets2add.update(nets2edit) Line 155: nets2remove.update(nets2edit) Line 156: Line 157: with ovs_switch.transaction(in_rollback, networks, bondings): Line 158: ovs_switch.setup(_ovs_info, nets2add, nets2remove, bonds2add, > netswitch cannot know about the driver, this is an OVS switch detail. lazy petr, i will create it twice, it should be cheap. plus it will keep it simple. Line 159: bonds2edit, bonds2remove) Line 160: ovs_switch.cleanup() Line 161: _setup_ipv6autoconf(networks) Line 162: _set_ovs_links_up(nets2add, bonds2add, bonds2edit) -- To view, visit https://gerrit.ovirt.org/59903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a6b7bb45cf111ab522812b5bc46d38c4baec451 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
